| Message ID | 20220201111455.52511-10-imp@bsdimp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | bsd-user: Start upstreaming the system calls. | expand |
On Tue, Feb 1, 2022 at 5:15 AM Warner Losh <imp@bsdimp.com> wrote: > > While there is some commonality between *BSD syscall processing, there's > a number of differences and the system call numbers and ABIs have been > independent since the late 90s. Move FreeBSD's proessing here and delete > it. > "processing" > The upstream implementation is somewhat different than the current > implementation. It will be much easier to upstream these from scratch, > justifying the final result, rather than working out the diffs and > justifying the changes. Also tweak a comment to qemu standard form. > > Signed-off-by: Warner Losh <imp@bsdimp.com> > --- > bsd-user/freebsd/os-syscall.c | 68 +++++++++++++++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 bsd-user/freebsd/os-syscall.c > > diff --git a/bsd-user/freebsd/os-syscall.c b/bsd-user/freebsd/os-syscall.c > new file mode 100644 > index 00000000000..7e2bedb918d > --- /dev/null > +++ b/bsd-user/freebsd/os-syscall.c > @@ -0,0 +1,68 @@ > +/* > + * BSD syscalls > + * > + * Copyright (c) 2003-2008 Fabrice Bellard > + * Copyright (c) 2013-2014 Stacey D. Son > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, see <http://www.gnu.org/licenses/>. > + */ > + > +/* > + * We need the FreeBSD "legacy" definitions. Rust needs the FreeBSD 11 system > + * calls, so we have to emulate that despite FreeBSD being EOL'd. > + */ ... FreeBSD 11 being EOL'd. > +#define _WANT_FREEBSD11_STAT > +#define _WANT_FREEBSD11_STATFS > +#define _WANT_FREEBSD11_DIRENT > +#define _WANT_KERNEL_ERRNO > +#define _WANT_SEMUN > +#include "qemu/osdep.h" > +#include "qemu/cutils.h" > +#include "qemu/path.h" > +#include <sys/syscall.h> > +#include <sys/param.h> > +#include <sys/sysctl.h> > +#include <utime.h> > + > +#include "qemu.h" > +#include "qemu-common.h" > +#include "signal-common.h" > +#include "user/syscall-trace.h" > + > +void target_set_brk(abi_ulong new_brk) > +{ > +} > + > +bool is_error(abi_long ret) > +{ > + > + return (abi_ulong)ret >= (abi_ulong)(-4096); > +} > + > +/* > + * do_syscall() should always have a single exit point at the end so that > + * actions, such as logging of syscall results, can be performed. All errnos > + * that do_syscall() returns must be -TARGET_<errcode>. > + */ > +abi_long do_freebsd_syscall(void *cpu_env, int num, abi_long arg1, > + abi_long arg2, abi_long arg3, abi_long arg4, > + abi_long arg5, abi_long arg6, abi_long arg7, > + abi_long arg8) > +{ > + return 0; > +} > + > +void syscall_init(void) > +{ > +} > -- > 2.33.1 > Small typo + omission, otherwise: Reviewed-by: Kyle Evans <kevans@FreeBSD.org>
On 2/1/22 22:14, Warner Losh wrote: > While there is some commonality between *BSD syscall processing, there's > a number of differences and the system call numbers and ABIs have been > independent since the late 90s. Move FreeBSD's proessing here and delete > it. > > The upstream implementation is somewhat different than the current > implementation. It will be much easier to upstream these from scratch, > justifying the final result, rather than working out the diffs and > justifying the changes. Also tweak a comment to qemu standard form. > > Signed-off-by: Warner Losh<imp@bsdimp.com> > --- > bsd-user/freebsd/os-syscall.c | 68 +++++++++++++++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 bsd-user/freebsd/os-syscall.c Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/bsd-user/freebsd/os-syscall.c b/bsd-user/freebsd/os-syscall.c new file mode 100644 index 00000000000..7e2bedb918d --- /dev/null +++ b/bsd-user/freebsd/os-syscall.c @@ -0,0 +1,68 @@ +/* + * BSD syscalls + * + * Copyright (c) 2003-2008 Fabrice Bellard + * Copyright (c) 2013-2014 Stacey D. Son + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, see <http://www.gnu.org/licenses/>. + */ + +/* + * We need the FreeBSD "legacy" definitions. Rust needs the FreeBSD 11 system + * calls, so we have to emulate that despite FreeBSD being EOL'd. + */ +#define _WANT_FREEBSD11_STAT +#define _WANT_FREEBSD11_STATFS +#define _WANT_FREEBSD11_DIRENT +#define _WANT_KERNEL_ERRNO +#define _WANT_SEMUN +#include "qemu/osdep.h" +#include "qemu/cutils.h" +#include "qemu/path.h" +#include <sys/syscall.h> +#include <sys/param.h> +#include <sys/sysctl.h> +#include <utime.h> + +#include "qemu.h" +#include "qemu-common.h" +#include "signal-common.h" +#include "user/syscall-trace.h" + +void target_set_brk(abi_ulong new_brk) +{ +} + +bool is_error(abi_long ret) +{ + + return (abi_ulong)ret >= (abi_ulong)(-4096); +} + +/* + * do_syscall() should always have a single exit point at the end so that + * actions, such as logging of syscall results, can be performed. All errnos + * that do_syscall() returns must be -TARGET_<errcode>. + */ +abi_long do_freebsd_syscall(void *cpu_env, int num, abi_long arg1, + abi_long arg2, abi_long arg3, abi_long arg4, + abi_long arg5, abi_long arg6, abi_long arg7, + abi_long arg8) +{ + return 0; +} + +void syscall_init(void) +{ +}
While there is some commonality between *BSD syscall processing, there's a number of differences and the system call numbers and ABIs have been independent since the late 90s. Move FreeBSD's proessing here and delete it. The upstream implementation is somewhat different than the current implementation. It will be much easier to upstream these from scratch, justifying the final result, rather than working out the diffs and justifying the changes. Also tweak a comment to qemu standard form. Signed-off-by: Warner Losh <imp@bsdimp.com> --- bsd-user/freebsd/os-syscall.c | 68 +++++++++++++++++++++++++++++++++++ 1 file changed, 68 insertions(+) create mode 100644 bsd-user/freebsd/os-syscall.c