| Message ID | 20220201111455.52511-7-imp@bsdimp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | bsd-user: Start upstreaming the system calls. | expand |
On Tue, Feb 1, 2022 at 5:14 AM Warner Losh <imp@bsdimp.com> wrote: > > Since we can't run on anything else, assume for the moment that this is > a FreeBSD target. In the future, we'll need to handle this properly > via some include file in bsd-user/*bsd/arm/mumble.h. There's a number > of other diffs that would be needed to make things work on OtherBSD, > so it doesn't make sense to preseve this one detail today. > > Signed-off-by: Warner Losh <imp@bsdimp.com> > --- > bsd-user/arm/target_arch_thread.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > Reviewed-by: Kyle Evans <kevans@FreeBSD.org> > diff --git a/bsd-user/arm/target_arch_thread.h b/bsd-user/arm/target_arch_thread.h > index 11c7f765838..fcafca2408c 100644 > --- a/bsd-user/arm/target_arch_thread.h > +++ b/bsd-user/arm/target_arch_thread.h > @@ -62,9 +62,7 @@ static inline void target_thread_init(struct target_pt_regs *regs, > } > regs->ARM_pc = infop->entry & 0xfffffffe; > regs->ARM_sp = stack; > - if (bsd_type == target_freebsd) { > - regs->ARM_lr = infop->entry & 0xfffffffe; > - } > + regs->ARM_lr = infop->entry & 0xfffffffe; > /* > * FreeBSD kernel passes the ps_strings pointer in r0. This is used by some > * programs to set status messages that we see in ps. bsd-user doesn't > -- > 2.33.1 >
On 2/1/22 22:14, Warner Losh wrote: > Since we can't run on anything else, assume for the moment that this is > a FreeBSD target. In the future, we'll need to handle this properly > via some include file in bsd-user/*bsd/arm/mumble.h. There's a number > of other diffs that would be needed to make things work on OtherBSD, > so it doesn't make sense to preseve this one detail today. > > Signed-off-by: Warner Losh<imp@bsdimp.com> > --- > bsd-user/arm/target_arch_thread.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/bsd-user/arm/target_arch_thread.h b/bsd-user/arm/target_arch_thread.h index 11c7f765838..fcafca2408c 100644 --- a/bsd-user/arm/target_arch_thread.h +++ b/bsd-user/arm/target_arch_thread.h @@ -62,9 +62,7 @@ static inline void target_thread_init(struct target_pt_regs *regs, } regs->ARM_pc = infop->entry & 0xfffffffe; regs->ARM_sp = stack; - if (bsd_type == target_freebsd) { - regs->ARM_lr = infop->entry & 0xfffffffe; - } + regs->ARM_lr = infop->entry & 0xfffffffe; /* * FreeBSD kernel passes the ps_strings pointer in r0. This is used by some * programs to set status messages that we see in ps. bsd-user doesn't
Since we can't run on anything else, assume for the moment that this is a FreeBSD target. In the future, we'll need to handle this properly via some include file in bsd-user/*bsd/arm/mumble.h. There's a number of other diffs that would be needed to make things work on OtherBSD, so it doesn't make sense to preseve this one detail today. Signed-off-by: Warner Losh <imp@bsdimp.com> --- bsd-user/arm/target_arch_thread.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)