| Message ID | 20220201111455.52511-8-imp@bsdimp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | bsd-user: Start upstreaming the system calls. | expand |
On Tue, Feb 1, 2022 at 5:15 AM Warner Losh <imp@bsdimp.com> wrote: > > Since we can't run on anything else, assume for the moment that this is > a FreeBSD target. In the future, we'll need to handle this properly via > some include file in bsd-user/*bsd/x86_64/mumble.h. There's a number of > other diffs that would be needed to make things work on OtherBSD, so it > doesn't make sense to preseve this one detail today. > > Signed-off-by: Warner Losh <imp@bsdimp.com> > --- > bsd-user/x86_64/target_arch_thread.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > Reviewed-by: Kyle Evans <kevans@FreeBSD.org> > diff --git a/bsd-user/x86_64/target_arch_thread.h b/bsd-user/x86_64/target_arch_thread.h > index d105e43fd35..b745d7ffeb7 100644 > --- a/bsd-user/x86_64/target_arch_thread.h > +++ b/bsd-user/x86_64/target_arch_thread.h > @@ -32,9 +32,7 @@ static inline void target_thread_init(struct target_pt_regs *regs, > regs->rax = 0; > regs->rsp = infop->start_stack; > regs->rip = infop->entry; > - if (bsd_type == target_freebsd) { > - regs->rdi = infop->start_stack; > - } > + regs->rdi = infop->start_stack; > } > > #endif /* !_TARGET_ARCH_THREAD_H_ */ > -- > 2.33.1 >
On 2/1/22 22:14, Warner Losh wrote: > Since we can't run on anything else, assume for the moment that this is > a FreeBSD target. In the future, we'll need to handle this properly via > some include file in bsd-user/*bsd/x86_64/mumble.h. There's a number of > other diffs that would be needed to make things work on OtherBSD, so it > doesn't make sense to preseve this one detail today. > > Signed-off-by: Warner Losh<imp@bsdimp.com> > --- > bsd-user/x86_64/target_arch_thread.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/bsd-user/x86_64/target_arch_thread.h b/bsd-user/x86_64/target_arch_thread.h index d105e43fd35..b745d7ffeb7 100644 --- a/bsd-user/x86_64/target_arch_thread.h +++ b/bsd-user/x86_64/target_arch_thread.h @@ -32,9 +32,7 @@ static inline void target_thread_init(struct target_pt_regs *regs, regs->rax = 0; regs->rsp = infop->start_stack; regs->rip = infop->entry; - if (bsd_type == target_freebsd) { - regs->rdi = infop->start_stack; - } + regs->rdi = infop->start_stack; } #endif /* !_TARGET_ARCH_THREAD_H_ */
Since we can't run on anything else, assume for the moment that this is a FreeBSD target. In the future, we'll need to handle this properly via some include file in bsd-user/*bsd/x86_64/mumble.h. There's a number of other diffs that would be needed to make things work on OtherBSD, so it doesn't make sense to preseve this one detail today. Signed-off-by: Warner Losh <imp@bsdimp.com> --- bsd-user/x86_64/target_arch_thread.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)