| Message ID | 20220528091934.15520-3-mark.cave-ayland@ilande.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/acpi/piix4: remove legacy piix4_pm_init() function | expand |
On Sat, May 28, 2022 at 2:49 PM Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> wrote: > > This is in preparation for conversion to a qdev property. > > Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> other than the comment below, Reviewed-by: Ani Sinha <ani@anisinha.ca> > --- > hw/acpi/piix4.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c > index bf20fa139b..fcfaafc175 100644 > --- a/hw/acpi/piix4.c > +++ b/hw/acpi/piix4.c > @@ -74,7 +74,7 @@ struct PIIX4PMState { > > qemu_irq irq; > qemu_irq smi_irq; > - int smm_enabled; > + bool smm_enabled; For the sake of consistency, I would also change the signature of piix4_pm_init(), that is, change simm_enabled from int to bool. We are good in pc_init1 since x86_machine_is_smm_enabled() returns bool. In piix4_create() in isa, we pass integer 0 which we might want to make boolean. > bool smm_compat; > Notifier machine_ready; > Notifier powerdown_notifier; > -- > 2.20.1 >
On 30/5/22 06:56, Ani Sinha wrote: > On Sat, May 28, 2022 at 2:49 PM Mark Cave-Ayland > <mark.cave-ayland@ilande.co.uk> wrote: >> >> This is in preparation for conversion to a qdev property. >> >> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> > > other than the comment below, > Reviewed-by: Ani Sinha <ani@anisinha.ca> > >> --- >> hw/acpi/piix4.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c >> index bf20fa139b..fcfaafc175 100644 >> --- a/hw/acpi/piix4.c >> +++ b/hw/acpi/piix4.c >> @@ -74,7 +74,7 @@ struct PIIX4PMState { >> >> qemu_irq irq; >> qemu_irq smi_irq; >> - int smm_enabled; >> + bool smm_enabled; > > For the sake of consistency, I would also change the signature of > piix4_pm_init(), that is, change simm_enabled from int to bool. > We are good in pc_init1 since x86_machine_is_smm_enabled() returns > bool. In piix4_create() in isa, we pass integer 0 which we might want > to make boolean. This function ends up removed... But OK.
diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index bf20fa139b..fcfaafc175 100644 --- a/hw/acpi/piix4.c +++ b/hw/acpi/piix4.c @@ -74,7 +74,7 @@ struct PIIX4PMState { qemu_irq irq; qemu_irq smi_irq; - int smm_enabled; + bool smm_enabled; bool smm_compat; Notifier machine_ready; Notifier powerdown_notifier;
This is in preparation for conversion to a qdev property. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> --- hw/acpi/piix4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)