diff mbox series

[v2,01/40] xen/arm: remove xen_phys_start and xenheap_phys_end from config.h

Message ID 20230113052914.3845596-2-Penny.Zheng@arm.com (mailing list archive)
State New, archived
Headers show
Series xen/arm: Add Armv8-R64 MPU support to Xen - Part#1 | expand

Commit Message

Penny Zheng Jan. 13, 2023, 5:28 a.m. UTC 
From: Wei Chen <wei.chen@arm.com>

These two variables are stale variables, they only have declarations
in config.h, they don't have any definition and no any code is using
these two variables. So in this patch, we remove them from config.h.

Signed-off-by: Wei Chen <wei.chen@arm.com>
Acked-by: Julien Grall <jgrall@amazon.com>
---
v1 -> v2:
1. Add Ab.
---
 xen/arch/arm/include/asm/config.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Julien Grall Jan. 13, 2023, 10:06 a.m. UTC | #1 
Hi Penny,

On 13/01/2023 05:28, Penny Zheng wrote:
> From: Wei Chen <wei.chen@arm.com>
> 
> These two variables are stale variables, they only have declarations
> in config.h, they don't have any definition and no any code is using
> these two variables. So in this patch, we remove them from config.h.
> 
> Signed-off-by: Wei Chen <wei.chen@arm.com>
> Acked-by: Julien Grall <jgrall@amazon.com>

I was going to commit this patch, however this technically needs your 
signed-off-by as the sender of this new version.

If you confirm your signed-off-by, then I can commit without a resending.

Cheers,
Penny Zheng Jan. 13, 2023, 10:39 a.m. UTC | #2 
> -----Original Message-----
> From: Julien Grall <julien@xen.org>
> Sent: Friday, January 13, 2023 6:07 PM
> To: Penny Zheng <Penny.Zheng@arm.com>; xen-devel@lists.xenproject.org
> Cc: Wei Chen <Wei.Chen@arm.com>; Stefano Stabellini
> <sstabellini@kernel.org>; Bertrand Marquis <Bertrand.Marquis@arm.com>;
> Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>; Julien Grall
> <jgrall@amazon.com>
> Subject: Re: [PATCH v2 01/40] xen/arm: remove xen_phys_start and
> xenheap_phys_end from config.h
> 
> Hi Penny,

Hi Julien

> 
> On 13/01/2023 05:28, Penny Zheng wrote:
> > From: Wei Chen <wei.chen@arm.com>
> >
> > These two variables are stale variables, they only have declarations
> > in config.h, they don't have any definition and no any code is using
> > these two variables. So in this patch, we remove them from config.h.
> >
> > Signed-off-by: Wei Chen <wei.chen@arm.com>
> > Acked-by: Julien Grall <jgrall@amazon.com>
> 
> I was going to commit this patch, however this technically needs your signed-
> off-by as the sender of this new version.
> 
> If you confirm your signed-off-by, then I can commit without a resending.
> 

Yes, I confirm, thx

> Cheers,
> 
> --
> Julien Grall
diff mbox series

Patch

diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h
index 0fefed1b8a..25a625ff08 100644
--- a/xen/arch/arm/include/asm/config.h
+++ b/xen/arch/arm/include/asm/config.h
@@ -172,8 +172,6 @@ 
 #define STACK_SIZE  (PAGE_SIZE << STACK_ORDER)
 
 #ifndef __ASSEMBLY__
-extern unsigned long xen_phys_start;
-extern unsigned long xenheap_phys_end;
 extern unsigned long frametable_virt_end;
 #endif