| Message ID | 20210309163656.20944-13-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Nobuhiro Iwamatsu |
| Headers | show |
| Series | Renesas RZ/G2{E,H,M,N} add VIN, CSI2 support | expand |
Hi! > From: Andrey Konovalov <andrey.konovalov@linaro.org> > > commit 9d730f2cf4c0391785855dd231577d2de2594df9 upstream. > > Add YAML device tree binding for IMX219 CMOS image sensor, and > the relevant MAINTAINERS entries. > +title: Sony 1/4.0-Inch 8Mpixel CMOS Digital Image Sensor > + > +maintainers: > + - Dave Stevenson <dave.stevenson@raspberrypi.com> > + > +description: |- > + The Sony imx219 is a 1/4.0-inch CMOS active pixel digital image sensor I assume it is 0.25 inch sensor? 1/4 inch or 0.25 inch would be understandable, but 1/4.0 is kind of strange. > + imx219: sensor@10 { > + compatible = "sony,imx219"; > + reg = <0x10>; > + clocks = <&imx219_clk>; > + VANA-supply = <&imx219_vana>; /* 2.8v */ > + VDIG-supply = <&imx219_vdig>; /* 1.8v */ > + VDDL-supply = <&imx219_vddl>; /* 1.2v */ "V" should be uppercase in voltages. Best regards, Pavel
Hi Pavel, Thank you for the review. > -----Original Message----- > From: Pavel Machek <pavel@denx.de> > Sent: 09 March 2021 18:52 > To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com> > Cc: cip-dev@lists.cip-project.org; Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek > <pavel@denx.de>; Biju Das <biju.das.jz@bp.renesas.com> > Subject: Re: [PATCH 4.19.y-cip 12/40] media: dt-bindings: media: i2c: Add IMX219 CMOS sensor binding > > Hi! > > > From: Andrey Konovalov <andrey.konovalov@linaro.org> > > > > commit 9d730f2cf4c0391785855dd231577d2de2594df9 upstream. > > > > Add YAML device tree binding for IMX219 CMOS image sensor, and > > the relevant MAINTAINERS entries. > > > +title: Sony 1/4.0-Inch 8Mpixel CMOS Digital Image Sensor > > + > > +maintainers: > > + - Dave Stevenson <dave.stevenson@raspberrypi.com> > > + > > +description: |- > > + The Sony imx219 is a 1/4.0-inch CMOS active pixel digital image sensor > > I assume it is 0.25 inch sensor? 1/4 inch or 0.25 inch would be > understandable, but 1/4.0 is kind of strange. > Agree with you here, but looking at the document [1] its referred the same way "1/4.0". [1] http://www.opensourceinstruments.com/Electronics/Data/IMX219PQ.pdf Cheers, Prabhakar > > > + imx219: sensor@10 { > > + compatible = "sony,imx219"; > > + reg = <0x10>; > > + clocks = <&imx219_clk>; > > + VANA-supply = <&imx219_vana>; /* 2.8v */ > > + VDIG-supply = <&imx219_vdig>; /* 1.8v */ > > + VDDL-supply = <&imx219_vddl>; /* 1.2v */ > > "V" should be uppercase in voltages. > > Best regards, > Pavel > > -- > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#6264): https://lists.cip-project.org/g/cip-dev/message/6264 Mute This Topic: https://lists.cip-project.org/mt/81205355/4520388 Group Owner: cip-dev+owner@lists.cip-project.org Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/4520388/727948398/xyzzy [cip-dev@archiver.kernel.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi! > > > +description: |- > > > + The Sony imx219 is a 1/4.0-inch CMOS active pixel digital image sensor > > > > I assume it is 0.25 inch sensor? 1/4 inch or 0.25 inch would be > > understandable, but 1/4.0 is kind of strange. > > > Agree with you here, but looking at the document [1] its referred the same way "1/4.0". > > [1] http://www.opensourceinstruments.com/Electronics/Data/IMX219PQ.pdf It is refered as "Type 1/4.0" and I'm not really sure what it means. 1/4 inch is 6.35mm, but document states it is 4.6mm. https://www.photoreview.com.au/tips/buying/unravelling-sensor-sizes/ explains this system, but they use 1/4", not 1/4.0, and it translates that to 4.5mm. I guess easiest way is to say it is "4.8mm CMOS active pixel digital image sensor" and forget about confusing inch values. Best regards, Pavel
Hi Pavel, > -----Original Message----- > From: Pavel Machek <pavel@denx.de> > Sent: 10 March 2021 09:39 > To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com> > Cc: Pavel Machek <pavel@denx.de>; cip-dev@lists.cip-project.org; Nobuhiro Iwamatsu > <nobuhiro1.iwamatsu@toshiba.co.jp>; Biju Das <biju.das.jz@bp.renesas.com> > Subject: Re: [PATCH 4.19.y-cip 12/40] media: dt-bindings: media: i2c: Add IMX219 CMOS sensor binding > > Hi! > > > > > +description: |- > > > > + The Sony imx219 is a 1/4.0-inch CMOS active pixel digital image sensor > > > > > > I assume it is 0.25 inch sensor? 1/4 inch or 0.25 inch would be > > > understandable, but 1/4.0 is kind of strange. > > > > > Agree with you here, but looking at the document [1] its referred the same way "1/4.0". > > > > [1] http://www.opensourceinstruments.com/Electronics/Data/IMX219PQ.pdf > > It is refered as "Type 1/4.0" and I'm not really sure what it means. > > 1/4 inch is 6.35mm, but document states it is 4.6mm. > > https://www.photoreview.com.au/tips/buying/unravelling-sensor-sizes/ > Thanks for the pointer. > explains this system, but they use 1/4", not 1/4.0, and it translates > that to 4.5mm. > > I guess easiest way is to say it is "4.8mm CMOS active pixel digital > image sensor" and forget about confusing inch values. > Totally agree with you (^^4.5mm). Cheers, Prabhakar > Best regards, > Pavel > -- > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#6270): https://lists.cip-project.org/g/cip-dev/message/6270 Mute This Topic: https://lists.cip-project.org/mt/81205355/4520388 Group Owner: cip-dev+owner@lists.cip-project.org Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/4520388/727948398/xyzzy [cip-dev@archiver.kernel.org] -=-=-=-=-=-=-=-=-=-=-=-
diff --git a/Documentation/devicetree/bindings/media/i2c/imx219.yaml b/Documentation/devicetree/bindings/media/i2c/imx219.yaml new file mode 100644 index 000000000000..32d6b693274f --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/imx219.yaml @@ -0,0 +1,114 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/imx219.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sony 1/4.0-Inch 8Mpixel CMOS Digital Image Sensor + +maintainers: + - Dave Stevenson <dave.stevenson@raspberrypi.com> + +description: |- + The Sony imx219 is a 1/4.0-inch CMOS active pixel digital image sensor + with an active array size of 3280H x 2464V. It is programmable through + I2C interface. The I2C address is fixed to 0x10 as per sensor data sheet. + Image data is sent through MIPI CSI-2, which is configured as either 2 or + 4 data lanes. + +properties: + compatible: + const: sony,imx219 + + reg: + description: I2C device address + maxItems: 1 + + clocks: + maxItems: 1 + + VDIG-supply: + description: + Digital I/O voltage supply, 1.8 volts + + VANA-supply: + description: + Analog voltage supply, 2.8 volts + + VDDL-supply: + description: + Digital core voltage supply, 1.2 volts + + reset-gpios: + description: |- + Reference to the GPIO connected to the xclr pin, if any. + Must be released (set high) after all supplies are applied. + + # See ../video-interfaces.txt for more details + port: + type: object + properties: + endpoint: + type: object + properties: + data-lanes: + description: |- + The sensor supports either two-lane, or four-lane operation. + If this property is omitted four-lane operation is assumed. + For two-lane operation the property must be set to <1 2>. + items: + - const: 1 + - const: 2 + + clock-noncontinuous: + type: boolean + description: |- + MIPI CSI-2 clock is non-continuous if this property is present, + otherwise it's continuous. + + link-frequencies: + allOf: + - $ref: /schemas/types.yaml#/definitions/uint64-array + description: + Allowed data bus frequencies. + + required: + - link-frequencies + +required: + - compatible + - reg + - clocks + - VANA-supply + - VDIG-supply + - VDDL-supply + - port + +additionalProperties: false + +examples: + - | + i2c0 { + #address-cells = <1>; + #size-cells = <0>; + + imx219: sensor@10 { + compatible = "sony,imx219"; + reg = <0x10>; + clocks = <&imx219_clk>; + VANA-supply = <&imx219_vana>; /* 2.8v */ + VDIG-supply = <&imx219_vdig>; /* 1.8v */ + VDDL-supply = <&imx219_vddl>; /* 1.2v */ + + port { + imx219_0: endpoint { + remote-endpoint = <&csi1_ep>; + data-lanes = <1 2>; + clock-noncontinuous; + link-frequencies = /bits/ 64 <456000000>; + }; + }; + }; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index 1061db6fbc32..47986d4b599a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13565,6 +13565,14 @@ S: Maintained F: drivers/ssb/ F: include/linux/ssb/ +SONY IMX219 SENSOR DRIVER +M: Dave Stevenson <dave.stevenson@raspberrypi.com> +L: linux-media@vger.kernel.org +T: git git://linuxtv.org/media_tree.git +S: Maintained +F: drivers/media/i2c/imx219.c +F: Documentation/devicetree/bindings/media/i2c/imx219.yaml + SONY IMX258 SENSOR DRIVER M: Sakari Ailus <sakari.ailus@linux.intel.com> L: linux-media@vger.kernel.org