diff mbox series

[5/8] iio:light:pa12203001: Improve error reporting for problems during .remove()

Message ID 20220515155929.338656-6-u.kleine-koenig@pengutronix.de (mailing list archive)
State Accepted
Headers show
Series iio: Improve error reporting for problems during .remove for various i2c drivers | expand

Commit Message

Uwe Kleine-König May 15, 2022, 3:59 p.m. UTC
Returning an error value in an i2c remove callback results in a generic
error message being emitted by the i2c core, but otherwise it doesn't
make a difference. The device goes away anyhow and the devm cleanups are

So instead of triggering the generic i2c error message, emit a more
helpful message if a problem occurs and return 0 to suppress the generic

This patch is a preparation for making i2c remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
 drivers/iio/light/pa12203001.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
diff mbox series


diff --git a/drivers/iio/light/pa12203001.c b/drivers/iio/light/pa12203001.c
index 528fa5dd2b13..772874e707ae 100644
--- a/drivers/iio/light/pa12203001.c
+++ b/drivers/iio/light/pa12203001.c
@@ -397,13 +397,19 @@  static int pa12203001_probe(struct i2c_client *client,
 static int pa12203001_remove(struct i2c_client *client)
 	struct iio_dev *indio_dev = i2c_get_clientdata(client);
+	int ret;
-	return pa12203001_power_chip(indio_dev, PA12203001_CHIP_DISABLE);
+	ret = pa12203001_power_chip(indio_dev, PA12203001_CHIP_DISABLE);
+	if (ret)
+		dev_warn(&client->dev, "Failed to power down (%pe)\n",
+			 ERR_PTR(ret));
+	return 0;
 #if defined(CONFIG_PM_SLEEP) || defined(CONFIG_PM)