diff mbox series

[106/120] MIPS: PS2: FB: fb_tilecursor() placeholder

Message ID a937cf09cfbb48b26bd71dba2e7e0e6f0e5eb298.1567326213.git.noring@nocrew.org (mailing list archive)
State RFC
Headers show
Series Linux for the PlayStation 2 | expand

Commit Message

Fredrik Noring Sept. 1, 2019, 4:33 p.m. UTC
Drawing the cursor seems to require composition such as xor, which is
not possible here. If the character under the cursor was known, a simple
change of foreground and background colours could be implemented to
achieve the same effect.

Signed-off-by: Fredrik Noring <noring@nocrew.org>
---
 drivers/video/fbdev/ps2fb.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
diff mbox series

Patch

diff --git a/drivers/video/fbdev/ps2fb.c b/drivers/video/fbdev/ps2fb.c
index c63215efd07d..bbf9e1d9e3c1 100644
--- a/drivers/video/fbdev/ps2fb.c
+++ b/drivers/video/fbdev/ps2fb.c
@@ -1258,6 +1258,17 @@  static void ps2fb_cb_tileblit(struct fb_info *info, struct fb_tileblit *blit)
 	}
 }
 
+static void ps2fb_cb_tilecursor(struct fb_info *info,
+	struct fb_tilecursor *cursor)
+{
+	/*
+	 * FIXME: Drawing the cursor seems to require composition such as
+	 * xor, which is not possible here. If the character under the
+	 * cursor was known, a simple change of foreground and background
+	 * colors could be implemented to achieve the same effect.
+	 */
+}
+
 /**
  * ps2fb_cb_get_tilemax - maximum number of tiles
  * @info: frame buffer info object
@@ -1924,6 +1935,7 @@  static int init_console_buffer(struct platform_device *pdev,
 		.fb_tilecopy	= ps2fb_cb_tilecopy,
 		.fb_tilefill    = ps2fb_cb_tilefill,
 		.fb_tileblit    = ps2fb_cb_tileblit,
+		.fb_tilecursor  = ps2fb_cb_tilecursor,
 		.fb_get_tilemax = ps2fb_cb_get_tilemax
 	};