| Message ID | 20200803031132.1427063-1-bryan.odonoghue@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | wcn36xx: Add support for WCN3680 802.11ac | expand |
Bryan O'Donoghue <bryan.odonoghue@linaro.org> writes:
> This series adds support for the 802.11ac data-rates available on the WCN3680.
To review 36 patches is just too much, so I'm going to take this in
smaller pieces.
In the future please limit the patchset size:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#maximum_of_7-12_patches_per_patchset
On 26/08/2020 16:27, Kalle Valo wrote: > Bryan O'Donoghue <bryan.odonoghue@linaro.org> writes: > >> This series adds support for the 802.11ac data-rates available on the WCN3680. > > To review 36 patches is just too much, so I'm going to take this in > smaller pieces. > > In the future please limit the patchset size: > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#maximum_of_7-12_patches_per_patchset > OK, I will break this up into groups of 8-10 patches on the rebase. --- bod
Bryan O'Donoghue <bryan.odonoghue@linaro.org> writes: > On 26/08/2020 16:27, Kalle Valo wrote: >> Bryan O'Donoghue <bryan.odonoghue@linaro.org> writes: >> >>> This series adds support for the 802.11ac data-rates available on the WCN3680. >> >> To review 36 patches is just too much, so I'm going to take this in >> smaller pieces. >> >> In the future please limit the patchset size: >> >> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#maximum_of_7-12_patches_per_patchset >> > > OK, I will break this up into groups of 8-10 patches on the rebase. Great, thanks.
This series adds support for the 802.11ac data-rates available on the WCN3680. WCN3680: - Has one spatial stream - MCS9 80Mhz 400ns guard interval - 433.3 Mbps - RX STBC - LDPC (host dependant) - MU-MIMO (host dependant) - Tx beamformee (host dependant) Declared data-rates are around 200 Mbps https://preview.tinyurl.com/y2w3jb2b iw wlan0 link Connected to 04:d4:c4:3a:fd:f4 (on wlan0) SSID: linaro-test_5G freq: 5300 RX: 761467 bytes (4302 packets) TX: 2492 bytes (28 packets) signal: -29 dBm rx bitrate: 433.3 MBit/s VHT-MCS 9 80MHz short GI VHT-NSS 1 tx bitrate: 6.0 MBit/s bss flags: short-slot-time dtim period: 3 beacon int: 100 Test Hardware: 20MHz channels [ ID] Interval Bitrate [ 5] 0.00-60.00 sec 51.6 Mbits/sec [ 5] 0.00-60.16 sec 51.4 Mbits/sec 40MHz channels [ 5] 0.00-60.00 sec 109 Mbits/sec [ 5] 0.00-60.15 sec 109 Mbits/sec 80MHz channels [ 5] 0.00-60.00 sec 141 Mbits/sec [ 5] 0.00-60.01 sec 141 Mbits/sec db410c: [ ID] Interval Bitrate [ 5] 0.00-60.00 sec 47.9 Mbits/sec [ 5] 0.00-60.02 sec 47.7 Mbits/sec Sony M4 Aqua - believed to contain a 3680 with 3.10 downstream prima: 20MHz channels [ ID] Interval Bitrate [ 5] 0.00-60.00 sec 25.5 Mbits/sec [ 5] 0.00-60.16 sec 25.5 Mbits/sec 40MHz channels [ 5] 0.00-60.00 sec 50 Mbits/sec [ 5] 0.00-60.15 sec 50 Mbits/sec 80MHz channels [ 5] 0.00-60.00 sec 67.8 Mbits/sec [ 5] 0.00-60.01 sec 67.8 Mbits/sec The wcn3680 uses the same parameter passing mechanism as earlier versions 3620 and 3660 however it also supports extended VHT parameters for STA and BSS setup. I've taken the downstream firmware config almost as-is in terms of parameters send over the SMD bus to the target with the caveat of switching off power-save offload. I do have some housekeeping patches in the middle of this series where I functionally decompose some of the existing code, which in my opinion needed some attention before adding any more code to it. Lastly, I've tested on wcn3680 and wcn3620, since the extended VHT parameters only apply to wcn3680 the code-paths for wcn3620 should be the same for wcn3660. Bryan O'Donoghue (36): wcn36xx: Add ability to identify WCN3680 wcn36xx: Add ieee802.11 VHT flags wcn36xx: Add 802.11ac MCS rates wcn36xx: Specify ieee80211_rx_status.nss wcn36xx: Add 802.11ac HAL param bitfields wcn36xx: Add Supported rates V1 structure wcn36xx: Use existing pointers in wcn36xx_smd_config_bss_v1 wcn36xx: Set feature DOT11AC for wcn3680 wcn36xx: Add VHT fields to parameter data structures wcn36xx: Use V1 data structure to store supported rates wcn36xx: Add wcn36xx_set_default_rates_v1 wcn36xx: Add VHT rates to wcn36xx_update_allowed_rates() wcn36xx: Add wcn36xx_smd_set_sta_default_vht_params() wcn36xx: Add wcn36xx_smd_set_sta_default_ht_ldpc_params() wcn36xx: Add wcn36xx_smd_set_sta_vht_params() wcn36xx: Add wcn36xx_smd_set_sta_ht_ldpc_params() wcn36xx: Add wcn36xx_smd_set_bss_vht_params() wcn36xx: Add wrapper function wcn36xx_smd_set_sta_params_v1() wcn36xx: Define INIT_HAL_MSG_V1() wcn36xx: Convert to VHT parameter structure on wcn3680 wcn36xx: Functionally decompose wcn36xx_smd_config_sta() wcn36xx: Move wcn36xx_smd_set_sta_params() inside wcn36xx_smd_config_bss() wcn36xx: Move BSS parameter setup to wcn36xx_smd_set_bss_params() wcn36xx: Add wcn36xx_smd_config_bss_v0 wcn36xx: Update wcn36xx_smd_config_bss_v1() to operate internally wcn36xx: Convert to using wcn36xx_smd_config_bss_v0() wcn36xx: Remove dead code in wcn36xx_smd_config_bss() wcn36xx: Latch VHT specific BSS parameters to firmware wcn36xx: Add accessor macro HW_VALUE_CHANNEL for hardware channels wcn36xx: Use HW_VALUE_CHANNEL macro to get channel number wcn36xx: Add accessor macro HW_VALUE_PHY for PHY settings wcn36xx: Encode PHY mode for 80MHz channel in hw_value wcn36xx: Set PHY into correct mode for 80MHz channel width wcn36xx: Extend HAL param config list wcn36xx: Define wcn3680 specific firmware parameters wcn36xx: Add ability to download wcn3680 specific firmware parameters drivers/net/wireless/ath/wcn36xx/hal.h | 214 ++++++- drivers/net/wireless/ath/wcn36xx/main.c | 99 ++- drivers/net/wireless/ath/wcn36xx/smd.c | 678 ++++++++++++++------- drivers/net/wireless/ath/wcn36xx/txrx.c | 110 +++- drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 10 +- 5 files changed, 861 insertions(+), 250 deletions(-)