| Message ID | 20200321144110.5010-10-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | misc: Trivial static code analyzer fixes | expand |
On Sat, Mar 21, 2020 at 7:52 AM Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > Fix warning reported by Clang static code analyzer: > > CC hw/timer/stm32f2xx_timer.o > hw/timer/stm32f2xx_timer.c:225:9: warning: Value stored to 'value' is never read > value = timer_val; > ^ ~~~~~~~~~ > > Reported-by: Clang Static Analyzer > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > hw/timer/stm32f2xx_timer.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/timer/stm32f2xx_timer.c b/hw/timer/stm32f2xx_timer.c > index 06ec8a02c2..ba8694dcd3 100644 > --- a/hw/timer/stm32f2xx_timer.c > +++ b/hw/timer/stm32f2xx_timer.c > @@ -222,7 +222,6 @@ static void stm32f2xx_timer_write(void *opaque, hwaddr offset, > case TIM_PSC: > timer_val = stm32f2xx_ns_to_ticks(s, now) - s->tick_offset; > s->tim_psc = value & 0xFFFF; > - value = timer_val; > break; > case TIM_CNT: > timer_val = value; > -- > 2.21.1 > >
diff --git a/hw/timer/stm32f2xx_timer.c b/hw/timer/stm32f2xx_timer.c index 06ec8a02c2..ba8694dcd3 100644 --- a/hw/timer/stm32f2xx_timer.c +++ b/hw/timer/stm32f2xx_timer.c @@ -222,7 +222,6 @@ static void stm32f2xx_timer_write(void *opaque, hwaddr offset, case TIM_PSC: timer_val = stm32f2xx_ns_to_ticks(s, now) - s->tick_offset; s->tim_psc = value & 0xFFFF; - value = timer_val; break; case TIM_CNT: timer_val = value;
Fix warning reported by Clang static code analyzer: CC hw/timer/stm32f2xx_timer.o hw/timer/stm32f2xx_timer.c:225:9: warning: Value stored to 'value' is never read value = timer_val; ^ ~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/timer/stm32f2xx_timer.c | 1 - 1 file changed, 1 deletion(-)