| Message ID | 20200321144110.5010-2-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | misc: Trivial static code analyzer fixes | expand |
On Sat, Mar 21, 2020 at 7:42 AM Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > Fix warning reported by Clang static code analyzer: > > block.c:3167:5: warning: Value stored to 'ret' is never read > ret = bdrv_fill_options(&options, filename, &flags, &local_err); > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Fixes: 462f5bcf6 > Reported-by: Clang Static Analyzer > Suggested-by: Markus Armbruster <armbru@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > v2: Keep 'ret' assigned and check it (Markus) > --- > block.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block.c b/block.c > index a2542c977b..a6f069d8bd 100644 > --- a/block.c > +++ b/block.c > @@ -3165,7 +3165,7 @@ static BlockDriverState *bdrv_open_inherit(const char *filename, > } > > ret = bdrv_fill_options(&options, filename, &flags, &local_err); > - if (local_err) { > + if (ret < 0) { > goto fail; > } > > -- > 2.21.1 > >
diff --git a/block.c b/block.c index a2542c977b..a6f069d8bd 100644 --- a/block.c +++ b/block.c @@ -3165,7 +3165,7 @@ static BlockDriverState *bdrv_open_inherit(const char *filename, } ret = bdrv_fill_options(&options, filename, &flags, &local_err); - if (local_err) { + if (ret < 0) { goto fail; }
Fix warning reported by Clang static code analyzer: block.c:3167:5: warning: Value stored to 'ret' is never read ret = bdrv_fill_options(&options, filename, &flags, &local_err); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fixes: 462f5bcf6 Reported-by: Clang Static Analyzer Suggested-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- v2: Keep 'ret' assigned and check it (Markus) --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)