| Message ID | 20200321144110.5010-9-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | misc: Trivial static code analyzer fixes | expand |
On Sat, Mar 21, 2020 at 7:50 AM Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > Fix warnings reported by Clang static code analyzer: > > hw/timer/exynos4210_mct.c:1370:9: warning: Value stored to 'index' is never read > index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i); > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > hw/timer/exynos4210_mct.c:1399:9: warning: Value stored to 'index' is never read > index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i); > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > hw/timer/exynos4210_mct.c:1441:9: warning: Value stored to 'index' is never read > index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i); > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Reported-by: Clang Static Analyzer > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > hw/timer/exynos4210_mct.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/hw/timer/exynos4210_mct.c b/hw/timer/exynos4210_mct.c > index 944120aea5..c0a25e71ec 100644 > --- a/hw/timer/exynos4210_mct.c > +++ b/hw/timer/exynos4210_mct.c > @@ -1367,7 +1367,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr offset, > > case L0_TCNTB: case L1_TCNTB: > lt_i = GET_L_TIMER_IDX(offset); > - index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i); > > /* > * TCNTB is updated to internal register only after CNT expired. > @@ -1396,7 +1395,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr offset, > > case L0_ICNTB: case L1_ICNTB: > lt_i = GET_L_TIMER_IDX(offset); > - index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i); > > s->l_timer[lt_i].reg.wstat |= L_WSTAT_ICNTB_WRITE; > s->l_timer[lt_i].reg.cnt[L_REG_CNT_ICNTB] = value & > @@ -1438,7 +1436,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr offset, > > case L0_FRCNTB: case L1_FRCNTB: > lt_i = GET_L_TIMER_IDX(offset); > - index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i); > > DPRINTF("local timer[%d] FRCNTB write %llx\n", lt_i, value); > > -- > 2.21.1 > >
diff --git a/hw/timer/exynos4210_mct.c b/hw/timer/exynos4210_mct.c index 944120aea5..c0a25e71ec 100644 --- a/hw/timer/exynos4210_mct.c +++ b/hw/timer/exynos4210_mct.c @@ -1367,7 +1367,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr offset, case L0_TCNTB: case L1_TCNTB: lt_i = GET_L_TIMER_IDX(offset); - index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i); /* * TCNTB is updated to internal register only after CNT expired. @@ -1396,7 +1395,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr offset, case L0_ICNTB: case L1_ICNTB: lt_i = GET_L_TIMER_IDX(offset); - index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i); s->l_timer[lt_i].reg.wstat |= L_WSTAT_ICNTB_WRITE; s->l_timer[lt_i].reg.cnt[L_REG_CNT_ICNTB] = value & @@ -1438,7 +1436,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr offset, case L0_FRCNTB: case L1_FRCNTB: lt_i = GET_L_TIMER_IDX(offset); - index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i); DPRINTF("local timer[%d] FRCNTB write %llx\n", lt_i, value);
Fix warnings reported by Clang static code analyzer: hw/timer/exynos4210_mct.c:1370:9: warning: Value stored to 'index' is never read index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/timer/exynos4210_mct.c:1399:9: warning: Value stored to 'index' is never read index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/timer/exynos4210_mct.c:1441:9: warning: Value stored to 'index' is never read index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/timer/exynos4210_mct.c | 3 --- 1 file changed, 3 deletions(-)