| Message ID | 20200321144110.5010-6-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | misc: Trivial static code analyzer fixes | expand |
On 3/21/20 10:41 AM, Philippe Mathieu-Daudé wrote: > Fix warning reported by Clang static code analyzer: > > CC hw/ide/sii3112.o > hw/ide/sii3112.c:204:9: warning: Value stored to 'val' is never read > val = 0; > ^ ~ > > Fixes: a9dd6604 > Reported-by: Clang Static Analyzer > Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > v2: Fix the correct function (Aleksandar review) > --- > hw/ide/sii3112.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/hw/ide/sii3112.c b/hw/ide/sii3112.c > index 06605d7af2..b2ff6dd6d9 100644 > --- a/hw/ide/sii3112.c > +++ b/hw/ide/sii3112.c > @@ -42,7 +42,7 @@ static uint64_t sii3112_reg_read(void *opaque, hwaddr addr, > unsigned int size) > { > SiI3112PCIState *d = opaque; > - uint64_t val = 0; > + uint64_t val; > > switch (addr) { > case 0x00: > @@ -126,6 +126,7 @@ static uint64_t sii3112_reg_read(void *opaque, hwaddr addr, > break; > default: > val = 0; > + break; > } > trace_sii3112_read(size, addr, val); > return val; > @@ -201,7 +202,7 @@ static void sii3112_reg_write(void *opaque, hwaddr addr, > d->regs[1].sien = (val >> 16) & 0x3eed; > break; > default: > - val = 0; > + break; > } > } > > Acked-by: John Snow <jsnow@redhat.com>
diff --git a/hw/ide/sii3112.c b/hw/ide/sii3112.c index 06605d7af2..b2ff6dd6d9 100644 --- a/hw/ide/sii3112.c +++ b/hw/ide/sii3112.c @@ -42,7 +42,7 @@ static uint64_t sii3112_reg_read(void *opaque, hwaddr addr, unsigned int size) { SiI3112PCIState *d = opaque; - uint64_t val = 0; + uint64_t val; switch (addr) { case 0x00: @@ -126,6 +126,7 @@ static uint64_t sii3112_reg_read(void *opaque, hwaddr addr, break; default: val = 0; + break; } trace_sii3112_read(size, addr, val); return val; @@ -201,7 +202,7 @@ static void sii3112_reg_write(void *opaque, hwaddr addr, d->regs[1].sien = (val >> 16) & 0x3eed; break; default: - val = 0; + break; } }
Fix warning reported by Clang static code analyzer: CC hw/ide/sii3112.o hw/ide/sii3112.c:204:9: warning: Value stored to 'val' is never read val = 0; ^ ~ Fixes: a9dd6604 Reported-by: Clang Static Analyzer Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- v2: Fix the correct function (Aleksandar review) --- hw/ide/sii3112.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)