Message ID | 20210515173716.358295-11-philmd@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | hw: Various Kconfig fixes | expand |
On Sat, 15 May 2021, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé <f4bug@amsat.org> > > The VT82C686 device model misses various dependencies: > > /usr/bin/ld: libcommon.fa.p/hw_isa_vt82c686.c.o: in function `vt82c686b_realize': > hw/isa/vt82c686.c:622: undefined reference to `i8259_init' > /usr/bin/ld: hw/isa/vt82c686.c:624: undefined reference to `i8257_dma_init' > /usr/bin/ld: hw/isa/vt82c686.c:627: undefined reference to `mc146818_rtc_init' > > Add them. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu> > --- > hw/isa/Kconfig | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig > index 55e0003ce40..0703512209a 100644 > --- a/hw/isa/Kconfig > +++ b/hw/isa/Kconfig > @@ -49,6 +49,9 @@ config VT82C686 > select FDC > select USB_UHCI > select APM > + select I8257 > + select I8259 > + select MC146818RTC > > config SMC37C669 > bool >
On Sun, May 16, 2021 at 1:43 AM Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > From: Philippe Mathieu-Daudé <f4bug@amsat.org> > > The VT82C686 device model misses various dependencies: > > /usr/bin/ld: libcommon.fa.p/hw_isa_vt82c686.c.o: in function `vt82c686b_realize': > hw/isa/vt82c686.c:622: undefined reference to `i8259_init' > /usr/bin/ld: hw/isa/vt82c686.c:624: undefined reference to `i8257_dma_init' > /usr/bin/ld: hw/isa/vt82c686.c:627: undefined reference to `mc146818_rtc_init' > > Add them. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/isa/Kconfig | 3 +++ > 1 file changed, 3 insertions(+) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig index 55e0003ce40..0703512209a 100644 --- a/hw/isa/Kconfig +++ b/hw/isa/Kconfig @@ -49,6 +49,9 @@ config VT82C686 select FDC select USB_UHCI select APM + select I8257 + select I8259 + select MC146818RTC config SMC37C669 bool