[v2,06/12] hw/riscv/Kconfig: Add missing dependency MICROCHIP_PFSOC -> SERIAL

Commit Message

Philippe Mathieu-Daudé May 15, 2021, 5:37 p.m. UTC

Commit a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART
emulation") added a dependency on the SERIAL model, but forgot to
add the Kconfig selector.
Add the dependency to the MCHP_PFSOC_MMUART symbol to fix when
building the MICROCHIP_PFSOC machine stand-alone:

  /usr/bin/ld: libcommon.fa.p/hw_char_mchp_pfsoc_mmuart.c.o: in function `mchp_pfsoc_mmuart_create':
  hw/char/mchp_pfsoc_mmuart.c:79: undefined reference to `serial_mm_init'

Fixes: a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART emulation")
Acked-by: Paolo Bonzini <[e-mail]>
Signed-off-by: Philippe Mathieu-Daudé <[e-mail]>
---
Cc: Bin Meng <[e-mail]>
Cc: Alistair Francis <[e-mail]>
---
 hw/char/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Alistair Francis May 16, 2021, 10:45 p.m. UTC | #1

On Sun, May 16, 2021 at 3:44 AM Philippe Mathieu-Daudé
<[e-mail]> wrote:
>
> Commit a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART
> emulation") added a dependency on the SERIAL model, but forgot to
> add the Kconfig selector.
> Add the dependency to the MCHP_PFSOC_MMUART symbol to fix when
> building the MICROCHIP_PFSOC machine stand-alone:
>
>   /usr/bin/ld: libcommon.fa.p/hw_char_mchp_pfsoc_mmuart.c.o: in function `mchp_pfsoc_mmuart_create':
>   hw/char/mchp_pfsoc_mmuart.c:79: undefined reference to `serial_mm_init'
>
> Fixes: a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART emulation")
> Acked-by: Paolo Bonzini <[e-mail]>
> Signed-off-by: Philippe Mathieu-Daudé <[e-mail]>

Reviewed-by: Alistair Francis <[e-mail]>

Alistair

> ---
> Cc: Bin Meng <[e-mail]>
> Cc: Alistair Francis <[e-mail]>
> ---
>  hw/char/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/char/Kconfig b/hw/char/Kconfig
> index 4cf36ac637b..2e4f620b13e 100644
> --- a/hw/char/Kconfig
> +++ b/hw/char/Kconfig
> @@ -61,6 +61,7 @@ config AVR_USART
>
>  config MCHP_PFSOC_MMUART
>      bool
> +    select SERIAL
>
>  config SIFIVE_UART
>      bool
> --
> 2.26.3
>
>

Bin Meng May 17, 2021, 1:55 a.m. UTC | #2

On Sun, May 16, 2021 at 1:44 AM Philippe Mathieu-Daudé
<[e-mail]> wrote:
>
> Commit a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART
> emulation") added a dependency on the SERIAL model, but forgot to
> add the Kconfig selector.
> Add the dependency to the MCHP_PFSOC_MMUART symbol to fix when
> building the MICROCHIP_PFSOC machine stand-alone:
>
>   /usr/bin/ld: libcommon.fa.p/hw_char_mchp_pfsoc_mmuart.c.o: in function `mchp_pfsoc_mmuart_create':
>   hw/char/mchp_pfsoc_mmuart.c:79: undefined reference to `serial_mm_init'
>
> Fixes: a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART emulation")
> Acked-by: Paolo Bonzini <[e-mail]>
> Signed-off-by: Philippe Mathieu-Daudé <[e-mail]>
> ---
> Cc: Bin Meng <[e-mail]>
> Cc: Alistair Francis <[e-mail]>
> ---
>  hw/char/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Bin Meng <[e-mail]>

Patch

diff --git a/hw/char/Kconfig b/hw/char/Kconfig
index 4cf36ac637b..2e4f620b13e 100644
--- a/hw/char/Kconfig
+++ b/hw/char/Kconfig
@@ -61,6 +61,7 @@  config AVR_USART
 
 config MCHP_PFSOC_MMUART
     bool
+    select SERIAL
 
 config SIFIVE_UART
     bool