| Message ID | 20221201140811.142123-1-bmeng@tinylab.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/15] hw/riscv: Select MSI_NONBROKEN in SIFIVE_PLIC | expand |
On Fri, Dec 2, 2022 at 12:15 AM Bin Meng <bmeng@tinylab.org> wrote: > > hw/pci/Kconfig says MSI_NONBROKEN should be selected by interrupt > controllers regardless of how MSI is implemented. msi_nonbroken is > initialized to true in sifive_plic_realize(). > > Let SIFIVE_PLIC select MSI_NONBROKEN and drop the selection from > RISC-V machines. > > Signed-off-by: Bin Meng <bmeng@tinylab.org> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > > hw/intc/Kconfig | 1 + > hw/riscv/Kconfig | 5 ----- > 2 files changed, 1 insertion(+), 5 deletions(-) > > diff --git a/hw/intc/Kconfig b/hw/intc/Kconfig > index ecd2883ceb..1d4573e803 100644 > --- a/hw/intc/Kconfig > +++ b/hw/intc/Kconfig > @@ -78,6 +78,7 @@ config RISCV_IMSIC > > config SIFIVE_PLIC > bool > + select MSI_NONBROKEN > > config GOLDFISH_PIC > bool > diff --git a/hw/riscv/Kconfig b/hw/riscv/Kconfig > index 79ff61c464..167dc4cca6 100644 > --- a/hw/riscv/Kconfig > +++ b/hw/riscv/Kconfig > @@ -11,7 +11,6 @@ config MICROCHIP_PFSOC > select MCHP_PFSOC_IOSCB > select MCHP_PFSOC_MMUART > select MCHP_PFSOC_SYSREG > - select MSI_NONBROKEN > select RISCV_ACLINT > select SIFIVE_PDMA > select SIFIVE_PLIC > @@ -37,7 +36,6 @@ config RISCV_VIRT > imply TPM_TIS_SYSBUS > select RISCV_NUMA > select GOLDFISH_RTC > - select MSI_NONBROKEN > select PCI > select PCI_EXPRESS_GENERIC_BRIDGE > select PFLASH_CFI01 > @@ -53,7 +51,6 @@ config RISCV_VIRT > > config SIFIVE_E > bool > - select MSI_NONBROKEN > select RISCV_ACLINT > select SIFIVE_GPIO > select SIFIVE_PLIC > @@ -64,7 +61,6 @@ config SIFIVE_E > config SIFIVE_U > bool > select CADENCE > - select MSI_NONBROKEN > select RISCV_ACLINT > select SIFIVE_GPIO > select SIFIVE_PDMA > @@ -82,6 +78,5 @@ config SPIKE > bool > select RISCV_NUMA > select HTIF > - select MSI_NONBROKEN > select RISCV_ACLINT > select SIFIVE_PLIC > -- > 2.34.1 > >
diff --git a/hw/intc/Kconfig b/hw/intc/Kconfig index ecd2883ceb..1d4573e803 100644 --- a/hw/intc/Kconfig +++ b/hw/intc/Kconfig @@ -78,6 +78,7 @@ config RISCV_IMSIC config SIFIVE_PLIC bool + select MSI_NONBROKEN config GOLDFISH_PIC bool diff --git a/hw/riscv/Kconfig b/hw/riscv/Kconfig index 79ff61c464..167dc4cca6 100644 --- a/hw/riscv/Kconfig +++ b/hw/riscv/Kconfig @@ -11,7 +11,6 @@ config MICROCHIP_PFSOC select MCHP_PFSOC_IOSCB select MCHP_PFSOC_MMUART select MCHP_PFSOC_SYSREG - select MSI_NONBROKEN select RISCV_ACLINT select SIFIVE_PDMA select SIFIVE_PLIC @@ -37,7 +36,6 @@ config RISCV_VIRT imply TPM_TIS_SYSBUS select RISCV_NUMA select GOLDFISH_RTC - select MSI_NONBROKEN select PCI select PCI_EXPRESS_GENERIC_BRIDGE select PFLASH_CFI01 @@ -53,7 +51,6 @@ config RISCV_VIRT config SIFIVE_E bool - select MSI_NONBROKEN select RISCV_ACLINT select SIFIVE_GPIO select SIFIVE_PLIC @@ -64,7 +61,6 @@ config SIFIVE_E config SIFIVE_U bool select CADENCE - select MSI_NONBROKEN select RISCV_ACLINT select SIFIVE_GPIO select SIFIVE_PDMA @@ -82,6 +78,5 @@ config SPIKE bool select RISCV_NUMA select HTIF - select MSI_NONBROKEN select RISCV_ACLINT select SIFIVE_PLIC
hw/pci/Kconfig says MSI_NONBROKEN should be selected by interrupt controllers regardless of how MSI is implemented. msi_nonbroken is initialized to true in sifive_plic_realize(). Let SIFIVE_PLIC select MSI_NONBROKEN and drop the selection from RISC-V machines. Signed-off-by: Bin Meng <bmeng@tinylab.org> --- hw/intc/Kconfig | 1 + hw/riscv/Kconfig | 5 ----- 2 files changed, 1 insertion(+), 5 deletions(-)