diff mbox series

[06/15] hw/intc: sifive_plic: Drop PLICMode_H

Message ID 20221201140811.142123-6-bmeng@tinylab.org (mailing list archive)
State New, archived
Headers show
Series [01/15] hw/riscv: Select MSI_NONBROKEN in SIFIVE_PLIC | expand

Commit Message

Bin Meng Dec. 1, 2022, 2:08 p.m. UTC
H-mode has been removed since priv spec 1.10. Drop it.

Signed-off-by: Bin Meng <bmeng@tinylab.org>
---

 include/hw/intc/sifive_plic.h | 1 -
 hw/intc/sifive_plic.c         | 1 -
 2 files changed, 2 deletions(-)

Comments

Wilfred Mallawa Dec. 1, 2022, 11:57 p.m. UTC | #1
On Thu, 2022-12-01 at 22:08 +0800, Bin Meng wrote:
> H-mode has been removed since priv spec 1.10. Drop it.
> 
> Signed-off-by: Bin Meng <bmeng@tinylab.org>
> ---
> 
>  include/hw/intc/sifive_plic.h | 1 -
>  hw/intc/sifive_plic.c         | 1 -
>  2 files changed, 2 deletions(-)
Reviewed-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
> 
> diff --git a/include/hw/intc/sifive_plic.h
> b/include/hw/intc/sifive_plic.h
> index 134cf39a96..d3f45ec248 100644
> --- a/include/hw/intc/sifive_plic.h
> +++ b/include/hw/intc/sifive_plic.h
> @@ -33,7 +33,6 @@ DECLARE_INSTANCE_CHECKER(SiFivePLICState,
> SIFIVE_PLIC,
>  typedef enum PLICMode {
>      PLICMode_U,
>      PLICMode_S,
> -    PLICMode_H,
>      PLICMode_M
>  } PLICMode;
>  
> diff --git a/hw/intc/sifive_plic.c b/hw/intc/sifive_plic.c
> index 1cf156cf85..3f6ffb1d70 100644
> --- a/hw/intc/sifive_plic.c
> +++ b/hw/intc/sifive_plic.c
> @@ -42,7 +42,6 @@ static PLICMode char_to_mode(char c)
>      switch (c) {
>      case 'U': return PLICMode_U;
>      case 'S': return PLICMode_S;
> -    case 'H': return PLICMode_H;
>      case 'M': return PLICMode_M;
>      default:
>          error_report("plic: invalid mode '%c'", c);
Alistair Francis Dec. 4, 2022, 10:25 p.m. UTC | #2
On Fri, Dec 2, 2022 at 12:15 AM Bin Meng <bmeng@tinylab.org> wrote:
>
> H-mode has been removed since priv spec 1.10. Drop it.
>
> Signed-off-by: Bin Meng <bmeng@tinylab.org>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>
>  include/hw/intc/sifive_plic.h | 1 -
>  hw/intc/sifive_plic.c         | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/include/hw/intc/sifive_plic.h b/include/hw/intc/sifive_plic.h
> index 134cf39a96..d3f45ec248 100644
> --- a/include/hw/intc/sifive_plic.h
> +++ b/include/hw/intc/sifive_plic.h
> @@ -33,7 +33,6 @@ DECLARE_INSTANCE_CHECKER(SiFivePLICState, SIFIVE_PLIC,
>  typedef enum PLICMode {
>      PLICMode_U,
>      PLICMode_S,
> -    PLICMode_H,
>      PLICMode_M
>  } PLICMode;
>
> diff --git a/hw/intc/sifive_plic.c b/hw/intc/sifive_plic.c
> index 1cf156cf85..3f6ffb1d70 100644
> --- a/hw/intc/sifive_plic.c
> +++ b/hw/intc/sifive_plic.c
> @@ -42,7 +42,6 @@ static PLICMode char_to_mode(char c)
>      switch (c) {
>      case 'U': return PLICMode_U;
>      case 'S': return PLICMode_S;
> -    case 'H': return PLICMode_H;
>      case 'M': return PLICMode_M;
>      default:
>          error_report("plic: invalid mode '%c'", c);
> --
> 2.34.1
>
>
diff mbox series

Patch

diff --git a/include/hw/intc/sifive_plic.h b/include/hw/intc/sifive_plic.h
index 134cf39a96..d3f45ec248 100644
--- a/include/hw/intc/sifive_plic.h
+++ b/include/hw/intc/sifive_plic.h
@@ -33,7 +33,6 @@  DECLARE_INSTANCE_CHECKER(SiFivePLICState, SIFIVE_PLIC,
 typedef enum PLICMode {
     PLICMode_U,
     PLICMode_S,
-    PLICMode_H,
     PLICMode_M
 } PLICMode;
 
diff --git a/hw/intc/sifive_plic.c b/hw/intc/sifive_plic.c
index 1cf156cf85..3f6ffb1d70 100644
--- a/hw/intc/sifive_plic.c
+++ b/hw/intc/sifive_plic.c
@@ -42,7 +42,6 @@  static PLICMode char_to_mode(char c)
     switch (c) {
     case 'U': return PLICMode_U;
     case 'S': return PLICMode_S;
-    case 'H': return PLICMode_H;
     case 'M': return PLICMode_M;
     default:
         error_report("plic: invalid mode '%c'", c);