| Message ID | 20231117101817.4401-10-quic_tengfan@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: qcom: add sm8550-aim300 board support | expand |
On 17/11/2023 11:18, Tengfei Fan wrote: > Enable PM8550 PMIC flash LED controller and add two flash LEDs using > four current outputs. > > Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> > --- NAK, it's initial submission. Stop useless splitting of work which is done. You cannot have "release late, release often". The rule is: "release early, release often". Or you want to split DTS per each line? Best regards, Krzysztof
在 11/17/2023 6:34 PM, Krzysztof Kozlowski 写道: > On 17/11/2023 11:18, Tengfei Fan wrote: >> Enable PM8550 PMIC flash LED controller and add two flash LEDs using >> four current outputs. >> >> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >> --- > > NAK, it's initial submission. > > Stop useless splitting of work which is done. You cannot have "release > late, release often". The rule is: "release early, release often". > > Or you want to split DTS per each line? > > Best regards, > Krzysztof > Hi Krzysztof, In next version patch series, I will do a board patch which contain all the functions which were splited in current patch series.
diff --git a/arch/arm64/boot/dts/qcom/sm8550-aim300.dts b/arch/arm64/boot/dts/qcom/sm8550-aim300.dts index 6a9b384c4e08..cafddc02aef0 100644 --- a/arch/arm64/boot/dts/qcom/sm8550-aim300.dts +++ b/arch/arm64/boot/dts/qcom/sm8550-aim300.dts @@ -5,6 +5,7 @@ /dts-v1/; +#include <dt-bindings/leds/common.h> #include <dt-bindings/regulator/qcom,rpmh-regulator.h> #include "sm8550.dtsi" #include "pm8010.dtsi" @@ -452,6 +453,30 @@ status = "okay"; }; +&pm8550_flash { + status = "okay"; + + led-0 { + function = LED_FUNCTION_FLASH; + color = <LED_COLOR_ID_YELLOW>; + flash-max-microamp = <2000000>; + flash-max-timeout-us = <1280000>; + function-enumerator = <0>; + led-sources = <1>, <4>; + led-max-microamp = <500000>; + }; + + led-1 { + function = LED_FUNCTION_FLASH; + color = <LED_COLOR_ID_WHITE>; + flash-max-microamp = <2000000>; + flash-max-timeout-us = <1280000>; + function-enumerator = <1>; + led-sources = <2>, <3>; + led-max-microamp = <500000>; + }; +}; + &pm8550b_eusb2_repeater { vdd18-supply = <&vreg_l15b_1p8>; vdd3-supply = <&vreg_l5b_3p1>;
Enable PM8550 PMIC flash LED controller and add two flash LEDs using four current outputs. Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> --- arch/arm64/boot/dts/qcom/sm8550-aim300.dts | 25 ++++++++++++++++++++++ 1 file changed, 25 insertions(+)