Message ID | 20231117101817.4401-14-quic_tengfan@quicinc.com (mailing list archive) |
---|---|
State | Changes Requested |
Headers | show |
Series | arm64: qcom: add sm8550-aim300 board support | expand |
On 17/11/2023 11:18, Tengfei Fan wrote: > Add Qualcomm WSA8845 Soundwire smart speaker amplifiers. > > Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> NAK, it's initial submission. Stop useless splitting of work which is done. You cannot have "release late, release often". The rule is: "release early, release often". Best regards, Krzysztof
在 11/17/2023 6:33 PM, Krzysztof Kozlowski 写道: > On 17/11/2023 11:18, Tengfei Fan wrote: >> Add Qualcomm WSA8845 Soundwire smart speaker amplifiers. >> >> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> > > NAK, it's initial submission. > > Stop useless splitting of work which is done. You cannot have "release > late, release often". The rule is: "release early, release often". > > Best regards, > Krzysztof > Hi Krzysztof, In next version patch series, I'm going to combine all the splited functions into one patch.
diff --git a/arch/arm64/boot/dts/qcom/sm8550-aim300.dts b/arch/arm64/boot/dts/qcom/sm8550-aim300.dts index c3f49527b9ad..e7035f57ce44 100644 --- a/arch/arm64/boot/dts/qcom/sm8550-aim300.dts +++ b/arch/arm64/boot/dts/qcom/sm8550-aim300.dts @@ -448,6 +448,24 @@ <&usb_dp_qmpphy QMP_USB43DP_USB3_PIPE_CLK>; }; +&lpass_tlmm { + spkr_1_sd_n_active: spkr-1-sd-n-active-state { + pins = "gpio17"; + function = "gpio"; + drive-strength = <16>; + bias-disable; + output-low; + }; + + spkr_2_sd_n_active: spkr-2-sd-n-active-state { + pins = "gpio18"; + function = "gpio"; + drive-strength = <16>; + bias-disable; + output-low; + }; +}; + &mdss { status = "okay"; }; @@ -612,6 +630,36 @@ clock-frequency = <32000>; }; +&swr0 { + status = "okay"; + + /* WSA8845, Speaker North */ + north_spkr: speaker@0,0 { + compatible = "sdw20217020400"; + reg = <0 0>; + pinctrl-0 = <&spkr_1_sd_n_active>; + pinctrl-names = "default"; + powerdown-gpios = <&lpass_tlmm 17 GPIO_ACTIVE_LOW>; + #sound-dai-cells = <0>; + sound-name-prefix = "SpkrLeft"; + vdd-1p8-supply = <&vreg_l15b_1p8>; + vdd-io-supply = <&vreg_l3g_1p2>; + }; + + /* WSA8845, Speaker South */ + south_spkr: speaker@0,1 { + compatible = "sdw20217020400"; + reg = <0 1>; + pinctrl-0 = <&spkr_2_sd_n_active>; + pinctrl-names = "default"; + powerdown-gpios = <&lpass_tlmm 18 GPIO_ACTIVE_LOW>; + #sound-dai-cells = <0>; + sound-name-prefix = "SpkrRight"; + vdd-1p8-supply = <&vreg_l15b_1p8>; + vdd-io-supply = <&vreg_l3g_1p2>; + }; +}; + &swr1 { status = "okay";
Add Qualcomm WSA8845 Soundwire smart speaker amplifiers. Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> --- arch/arm64/boot/dts/qcom/sm8550-aim300.dts | 48 ++++++++++++++++++++++ 1 file changed, 48 insertions(+)