diff mbox series

[11/16] arm64: dts: qcom: sm8550-aim300: add notification RGB LED

Message ID 20231117101817.4401-12-quic_tengfan@quicinc.com (mailing list archive)
State Changes Requested
Headers show
Series arm64: qcom: add sm8550-aim300 board support | expand

Commit Message

Tengfei Fan Nov. 17, 2023, 10:18 a.m. UTC
The QRD features a notification LED connected to the pm8550.
Configure the RGB led controlled by the PMIC PWM controller.

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sm8550-aim300.dts | 27 ++++++++++++++++++++++
 1 file changed, 27 insertions(+)

Comments

Krzysztof Kozlowski Nov. 17, 2023, 10:31 a.m. UTC | #1
On 17/11/2023 11:18, Tengfei Fan wrote:
> The QRD features a notification LED connected to the pm8550.
> Configure the RGB led controlled by the PMIC PWM controller.
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---

You just added this board. Does it mean you added incomplete and wrong DTS?

Best regards,
Krzysztof
Tengfei Fan Nov. 21, 2023, 1:01 a.m. UTC | #2
在 11/17/2023 6:31 PM, Krzysztof Kozlowski 写道:
> On 17/11/2023 11:18, Tengfei Fan wrote:
>> The QRD features a notification LED connected to the pm8550.
>> Configure the RGB led controlled by the PMIC PWM controller.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
> 
> You just added this board. Does it mean you added incomplete and wrong DTS?
> 
> Best regards,
> Krzysztof
> 

Hi Krzysztof,
In next version patch series, I'm going to combine all the splited 
functions into one patch.
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sm8550-aim300.dts b/arch/arm64/boot/dts/qcom/sm8550-aim300.dts
index 9b568ae9581e..40132073038d 100644
--- a/arch/arm64/boot/dts/qcom/sm8550-aim300.dts
+++ b/arch/arm64/boot/dts/qcom/sm8550-aim300.dts
@@ -517,6 +517,33 @@ 
 	};
 };
 
+&pm8550_pwm {
+	status = "okay";
+
+	multi-led {
+		color = <LED_COLOR_ID_RGB>;
+		function = LED_FUNCTION_STATUS;
+
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		led@1 {
+			reg = <1>;
+			color = <LED_COLOR_ID_RED>;
+		};
+
+		led@2 {
+			reg = <2>;
+			color = <LED_COLOR_ID_GREEN>;
+		};
+
+		led@3 {
+			reg = <3>;
+			color = <LED_COLOR_ID_BLUE>;
+		};
+	};
+};
+
 &pm8550b_eusb2_repeater {
 	vdd18-supply = <&vreg_l15b_1p8>;
 	vdd3-supply = <&vreg_l5b_3p1>;