| Message ID | 20231117101817.4401-6-quic_tengfan@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: qcom: add sm8550-aim300 board support | expand |
On 17/11/2023 12:18, Tengfei Fan wrote: > Address/size-cells will cause dtbs check warning, because mdss_dsi1 node > have not ranges and child also have not reg, so remove address/size-cells. > > Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sm8550.dtsi | 3 --- > 1 file changed, 3 deletions(-) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On 17/11/2023 12:24, Dmitry Baryshkov wrote: > On 17/11/2023 12:18, Tengfei Fan wrote: >> Address/size-cells will cause dtbs check warning, because mdss_dsi1 node >> have not ranges and child also have not reg, so remove >> address/size-cells. >> >> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/sm8550.dtsi | 3 --- >> 1 file changed, 3 deletions(-) > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > On the other hand, probably no. Panels beneath the DSI node will have single cell of address and 0 size cells. So these propeties are correct.
diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi index 52e8f4c52426..4d3650ad5d87 100644 --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi @@ -2771,9 +2771,6 @@ phys = <&mdss_dsi1_phy>; phy-names = "dsi"; - #address-cells = <1>; - #size-cells = <0>; - status = "disabled"; ports {
Address/size-cells will cause dtbs check warning, because mdss_dsi1 node have not ranges and child also have not reg, so remove address/size-cells. Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 3 --- 1 file changed, 3 deletions(-)