| Message ID | 20231117101817.4401-13-quic_tengfan@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: qcom: add sm8550-aim300 board support | expand |
On 17/11/2023 11:18, Tengfei Fan wrote: > The Volume Down & Power buttons are controlled by the PMIC via the PON > hardware, and the Volume Up is connected to a PMIC gpio. > > Enable the necessary hardware and setup the GPIO state for the Volume Up > gpio key. > > Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> > --- No, really, necessary hardware? So why it is missing in the previous patch? Stop useless splitting of work which is done. You cannot have "release late, release often". The rule is: "release early, release often". NAK. Best regards, Krzysztof
在 11/17/2023 6:32 PM, Krzysztof Kozlowski 写道: > On 17/11/2023 11:18, Tengfei Fan wrote: >> The Volume Down & Power buttons are controlled by the PMIC via the PON >> hardware, and the Volume Up is connected to a PMIC gpio. >> >> Enable the necessary hardware and setup the GPIO state for the Volume Up >> gpio key. >> >> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >> --- > > No, really, necessary hardware? So why it is missing in the previous patch? > > Stop useless splitting of work which is done. You cannot have "release > late, release often". The rule is: "release early, release often". > > NAK. > > Best regards, > Krzysztof > Hi Krzysztof, In next version patch series, I'm going to combine all the splited functions into one patch.
diff --git a/arch/arm64/boot/dts/qcom/sm8550-aim300.dts b/arch/arm64/boot/dts/qcom/sm8550-aim300.dts index 40132073038d..c3f49527b9ad 100644 --- a/arch/arm64/boot/dts/qcom/sm8550-aim300.dts +++ b/arch/arm64/boot/dts/qcom/sm8550-aim300.dts @@ -56,6 +56,22 @@ stdout-path = "serial0:115200n8"; }; + gpio-keys { + compatible = "gpio-keys"; + + pinctrl-0 = <&volume_up_n>; + pinctrl-names = "default"; + + key-volume-up { + label = "Volume Up"; + debounce-interval = <15>; + gpios = <&pm8550_gpios 6 GPIO_ACTIVE_LOW>; + linux,code = <KEY_VOLUMEUP>; + linux,can-disable; + wakeup-source; + }; + }; + pmic-glink { compatible = "qcom,sm8550-pmic-glink", "qcom,pmic-glink"; #address-cells = <1>; @@ -517,6 +533,16 @@ }; }; +&pm8550_gpios { + volume_up_n: volume-up-n-state { + pins = "gpio6"; + function = "normal"; + power-source = <1>; + bias-pull-up; + input-enable; + }; +}; + &pm8550_pwm { status = "okay"; @@ -549,6 +575,17 @@ vdd3-supply = <&vreg_l5b_3p1>; }; + +&pon_pwrkey { + status = "okay"; +}; + +&pon_resin { + linux,code = <KEY_VOLUMEDOWN>; + + status = "okay"; +}; + &qupv3_id_0 { status = "okay"; };
The Volume Down & Power buttons are controlled by the PMIC via the PON hardware, and the Volume Up is connected to a PMIC gpio. Enable the necessary hardware and setup the GPIO state for the Volume Up gpio key. Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> --- arch/arm64/boot/dts/qcom/sm8550-aim300.dts | 37 ++++++++++++++++++++++ 1 file changed, 37 insertions(+)