Message ID | 20240403112253.1432390-3-balasubramani.vivekanandan@intel.com (mailing list archive) |
---|---|
State | New |
Headers | show |
Series | Enable dislay support for Battlemage | expand |
On Wed, Apr 03, 2024 at 04:52:30PM +0530, Balasubramani Vivekanandan wrote: >diff --git a/include/drm/xe_pciids.h b/include/drm/xe_pciids.h >index c7fc288dacee..73d972a8aca1 100644 >--- a/include/drm/xe_pciids.h >+++ b/include/drm/xe_pciids.h >@@ -208,4 +208,11 @@ > MACRO__(0x64A0, ## __VA_ARGS__), \ > MACRO__(0x64B0, ## __VA_ARGS__) > >+#define XE_BMG_IDS(MACRO__, ...) \ >+ MACRO__(0xE202, ## __VA_ARGS__), \ >+ MACRO__(0xE20B, ## __VA_ARGS__), \ >+ MACRO__(0xE20C, ## __VA_ARGS__), \ >+ MACRO__(0xE20D, ## __VA_ARGS__), \ >+ MACRO__(0xE212, ## __VA_ARGS__) see my previous review. I don't think these patches are split correctly. We should postpone the PCI additions and let this one be only about adding the platform descriptor and definitions. The next patch adding IS_BATTLEMAGE() could be squashed in this one, while the PCI additions be separate in another patch. Lucas De Marchi
diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c index c47ab4b67467..b3158053baee 100644 --- a/drivers/gpu/drm/xe/xe_pci.c +++ b/drivers/gpu/drm/xe/xe_pci.c @@ -337,6 +337,12 @@ static const struct xe_device_desc lnl_desc = { .require_force_probe = true, }; +static const struct xe_device_desc bmg_desc = { + DGFX_FEATURES, + PLATFORM(XE_BATTLEMAGE), + .require_force_probe = true, +}; + #undef PLATFORM __diag_pop(); @@ -379,6 +385,7 @@ static const struct pci_device_id pciidlist[] = { XE_PVC_IDS(INTEL_VGA_DEVICE, &pvc_desc), XE_MTL_IDS(INTEL_VGA_DEVICE, &mtl_desc), XE_LNL_IDS(INTEL_VGA_DEVICE, &lnl_desc), + XE_BMG_IDS(INTEL_VGA_DEVICE, &bmg_desc), { } }; MODULE_DEVICE_TABLE(pci, pciidlist); diff --git a/drivers/gpu/drm/xe/xe_platform_types.h b/drivers/gpu/drm/xe/xe_platform_types.h index 553f53dbd093..79b7042c4534 100644 --- a/drivers/gpu/drm/xe/xe_platform_types.h +++ b/drivers/gpu/drm/xe/xe_platform_types.h @@ -22,6 +22,7 @@ enum xe_platform { XE_PVC, XE_METEORLAKE, XE_LUNARLAKE, + XE_BATTLEMAGE, }; enum xe_subplatform { diff --git a/include/drm/xe_pciids.h b/include/drm/xe_pciids.h index c7fc288dacee..73d972a8aca1 100644 --- a/include/drm/xe_pciids.h +++ b/include/drm/xe_pciids.h @@ -208,4 +208,11 @@ MACRO__(0x64A0, ## __VA_ARGS__), \ MACRO__(0x64B0, ## __VA_ARGS__) +#define XE_BMG_IDS(MACRO__, ...) \ + MACRO__(0xE202, ## __VA_ARGS__), \ + MACRO__(0xE20B, ## __VA_ARGS__), \ + MACRO__(0xE20C, ## __VA_ARGS__), \ + MACRO__(0xE20D, ## __VA_ARGS__), \ + MACRO__(0xE212, ## __VA_ARGS__) + #endif